Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDeviceRooted not working correctly #29

Closed
danielehrhardt opened this issue Aug 5, 2021 · 5 comments
Closed

isDeviceRooted not working correctly #29

danielehrhardt opened this issue Aug 5, 2021 · 5 comments

Comments

@danielehrhardt
Copy link
Contributor

image

When i call isDeviceRooted() on some devices i get true but when i try to install then with root i am getting a catch with the error that the Device is not rooted. I can say that the Firmware is singed with test keys. I am not sure if this helps.

Maybe we can find a different root detection.

@kolbasa
Copy link
Owner

kolbasa commented Aug 6, 2021

Hmm. I was afraid of something like that. I wanted to have a minimal solution to test the root status. I guess this is not enough. The root methods are often very different.

I'll have to include something like that: https://github.com/scottyab/rootbeer

Give me 1 or 2 days, I'll test it out.

@danielehrhardt
Copy link
Contributor Author

Hmm. I was afraid of something like that. I wanted to have a minimal solution to test the root status. I guess this is not enough. The root methods are often very different.

I'll have to include something like that: https://github.com/scottyab/rootbeer

Give me 1 or 2 days, I'll test it out.

If you have something to test send it over.

@kolbasa
Copy link
Owner

kolbasa commented Aug 7, 2021

isDeviceRooted() now uses the rootbeer library.

The change is now on the branch: root-tools:
cordova plugin add https://github.com/kolbasa/cordova-plugin-apkupdater#root-tools

Change is published with version: 2.5.0

@danielehrhardt
Copy link
Contributor Author

isDeviceRooted() now uses the rootbeer library.

The change is now on the branch: root-tools:
cordova plugin add https://github.com/kolbasa/cordova-plugin-apkupdater#root-tools

Change is published with version: 2.5.0

It does work now correctly.

@kolbasa
Copy link
Owner

kolbasa commented Aug 10, 2021

Glad to hear that. Let me know if you find anything else. 👍

@kolbasa kolbasa closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants