Authorization headers always sent

[rbot09]

Hi, first of all thanks for the plugin its great!,

I encounter a problem while using azure blobs for download weather I send basicAuth as null or not, seams like the request headers authorization: 'Basic bnVsbA==' are always sent. I believe In FileDownloader.java:46
if (basicAuth != null) { basicAuth = new String(Base64.encode(basicAuth.getBytes(), Base64.NO_WRAP)); connection.setRequestProperty("Authorization", "Basic " + basicAuth); }
basicAuth is not null all the time.

I did a test server to intercept both download examples below and the authorization header is always present causing issues with strict servers.

await window.ApkUpdater.download('http://192.168.1.14:8000/update.apk', { basicAuth: null, onDownloadProgress: (e) => { console.log(Downloading: ${e.progress} % (${e.bytesWritten} / ${e.bytes})`)
}
})

await window.ApkUpdater.download('http://192.168.1.14:8000/update.apk', {
onDownloadProgress: (e) => {
this.enforce_upgrade.download_progress = e.progress
console.log(Downloading: ${e.progress} % (${e.bytesWritten} / ${e.bytes}))
console.log(this.enforce_upgrade)
}
})

{
authorization: 'Basic bnVsbA==',
'user-agent': 'Dalvik/2.1.0 (Linux; U; Android 8.1.0; TC20 Build/01-11-09.00-OG-U00-H01)',
host: '192.168.1.14:8000',
connection: 'Keep-Alive',
'accept-encoding': 'gzip'
}
`

[kolbasa]

I just checked. Yes, you are right. That is a bug.
I'll fix it right now.

[kolbasa]

Bugfix is now released with version: 2.6.1

[rbot09]

This is working now thanks!