-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql: support simple arguments like offset
, limit
and distinct_on
#22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review completed
Functionality-wise: {
limitUsers: users(limit: 1) {
first_name
last_name
}
} I get this back with the users' alias changed to lowercase {
"data": {
"limitusers": [
{
"first_name": "Ikechukwu",
"last_name": "Eze"
}
]
}
} |
Everything works as expected (offset, limit and distinct_on). Great work @kolharsam ❤️🔥 |
Co-authored-by: Ikechukwu Eze <iykekings36@gmail.com>
Co-authored-by: Ikechukwu Eze <iykekings36@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️🔥
This PR does some clean-up of the code and resolves #12 and resolves #23 too
To test:
Schema: users(id serial primary key, first_name text, last_name text)