dont run tests without elevated permissions on windows, fix comments

pkg/osquery/runtime/runtime_posix_test.go

@@ -27,9 +27,15 @@ func requirePgidMatch(t *testing.T, pid int) {
 	require.Equal(t, pgid, pid)
 }
 
-// TestOsquerySlowStart tests that the launcher can handle a slow-starting osqueryd process.
-// This this is only enabled on non-Windows platforms because suspending we have not yet
-// figured out how to suspend a process on windows via golang.
+// hasPermissionsToRunTest always return true for non-windows platforms since
+// elveated permissions are not required to run the tests
+func hasPermissionsToRunTest() bool {
+	return true
+}
+
+// TestOsquerySlowStart tests that launcher can handle a slow-starting osqueryd process.
+// This this is only enabled on non-Windows platforms because we have not yet figured
+// out how to suspend and resume a process on Windows via golang.
 func TestOsquerySlowStart(t *testing.T) {
 	t.Parallel()
 	rootDirectory, rmRootDirectory, err := osqueryTempDir()

pkg/osquery/runtime/runtime_test.go

@@ -34,6 +34,11 @@ var testOsqueryBinaryDirectory string
 
 // TestMain overrides the default test main function. This allows us to share setup/teardown.
 func TestMain(m *testing.M) {
+	if !hasPermissionsToRunTest() {
+		fmt.Println("these tests must be run as an administrator on windows")
+		return
+	}
+
 	binDirectory, rmBinDirectory, err := osqueryTempDir()
 	if err != nil {
 		fmt.Println("Failed to make temp dir for test binaries")

pkg/osquery/runtime/runtime_windows_test.go

@@ -5,6 +5,14 @@ package runtime
 
 import (
 	"testing"
+
+	"golang.org/x/sys/windows"
 )
 
 func requirePgidMatch(_ *testing.T, _ int) {}
+
+// hasPermissionsToRunTest return true if the current process has elevated permissions (administrator),
+// this is required to run tests on windows
+func hasPermissionsToRunTest() bool {
+	return windows.GetCurrentProcessToken().IsElevated()
+}