Lock to govulncheck@v1.0.1 temporarily to avoid dirty tags #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
changed the title
James-Pickett
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this morning that all of our our latest builds are tagged with
-dirty. This doesn't appear to have anything to do with changes we've made in our CI.Through troubleshooting, I narrowed it down to the Jan 16 govulncheck v1.0.2 release -- installing and running this version modifies
go.sum, which results in a dirty state immediately before the build process, which runsgit describe ...to set launcher version.I think the issue is not golang/go#65130, but maybe similar/related.
Other options to consider besides locking to v1.0.1:
go mod tidyimmediately after running govulncheck