Set up tracing as early as possible to capture initial traces #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
approved these changes
Jan 27, 2024
| @@ -73,6 +74,9 @@ const ( | |||
| // rungroups with the various options, and goes! If autoupdate is | |||
| // enabled, the finalizers will trigger various restarts. | |||
| func runLauncher(ctx context.Context, cancel func(), multiSlogger, systemMultiSlogger *multislogger.MultiSlogger, opts *launcher.Options) error { | |||
| initialTraceBuffer := exporter.NewInitialTraceBuffer() | |||
| ctx, startupSpan := traces.StartSpan(ctx) | |||
There was a problem hiding this comment.
Can we name this span?
There was a problem hiding this comment.
It automatically gets the name main.runLauncher, which I felt was good enough? But we could also:
- add an attribute to this span that would "tag" it as a span of special interest
- add a new function to the
tracespackage to allow for starting a span with a specific name instead of the defaultnamespace.functionname
Let me know if you have a preference? Since you've approved, I'm going to merge, but I will have another PR up very shortly to add more child spans in this area for timing so I can make this change in that PR. 🙂
James-Pickett
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an initial trace buffer (plus tracer provider, etc) as soon as possible in runLauncher, before knapsack/osquery client are available. Transfer buffer and attrs to trace exporter once available.