Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message menu item #1571

Merged
merged 8 commits into from
Feb 2, 2024
Merged

Conversation

James-Pickett
Copy link
Contributor

No description provided.

@James-Pickett James-Pickett changed the title first pass message menu item Jan 31, 2024
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right.

One call out -- there's no real way we can auth from desktop to runner. I think that's inherent, and I'm not sure it's an issue. After all, the user can just use the menu. But short of moving everything to being in the user process, I don't think there's a fix

ee/control/control.go Outdated Show resolved Hide resolved
ee/control/control.go Outdated Show resolved Hide resolved
ee/desktop/runner/server/server.go Outdated Show resolved Hide resolved
RebeccaMahany
RebeccaMahany previously approved these changes Feb 1, 2024
@James-Pickett James-Pickett marked this pull request as ready for review February 1, 2024 18:10
@James-Pickett James-Pickett added this pull request to the merge queue Feb 2, 2024
Merged via the queue into kolide:main with commit 0274b94 Feb 2, 2024
26 checks passed
@James-Pickett James-Pickett deleted the james/message-menu-item branch February 2, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants