Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy autoupdater #1600

Merged
merged 2 commits into from Feb 14, 2024
Merged

Remove legacy autoupdater #1600

merged 2 commits into from Feb 14, 2024

Conversation

RebeccaMahany
Copy link
Contributor

This is part 2 of removing Notary from launcher: removing the now-unused portions of the legacy autoupdater.

Relates to #1577

@RebeccaMahany RebeccaMahany mentioned this pull request Feb 14, 2024
Open
6 tasks
directionless
directionless approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo! A little scary but I think good.

Still pending are maybe build updates to not include the repo, and cleanup stuff?

@RebeccaMahany
Copy link
Contributor Author

@directionless correct, up next are:

  • Deprecate Notary command-line options
  • Remove Notary assets from package-builder, and remove pkg/tools and bindata

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Feb 14, 2024
Merged via the queue into kolide:main with commit f230311 Feb 14, 2024
27 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/remove-notary-2 branch February 14, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

@zackattack01 zackattack01 zackattack01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RebeccaMahany @directionless @zackattack01