add database reset history to uninstall and add uninstall history checkup #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
previously approved these changes
Mar 4, 2024
James-Pickett
previously approved these changes
Mar 4, 2024
directionless
previously approved these changes
Mar 5, 2024
|
|
||
| for _, uninstallRecord := range resetRecords { | ||
| resetTimeKey := time.Unix(uninstallRecord.ResetTimestamp, 0) | ||
| hc.data[resetTimeKey.Format(time.RFC3339)] = map[string]any{ |
There was a problem hiding this comment.
This is fine, but feels like a bit of overkill. The time sorted array was probably fine
| return nil | ||
| } | ||
|
|
||
| resetRecordsRaw, err := hc.k.PersistentHostDataStore().Get(agent.HostDataKeyResetRecords) |
There was a problem hiding this comment.
Consider moving this to something like agent.GetResetRecords(ctx context.Context, k types.Knapsack) maybe.
There was a problem hiding this comment.
I will go ahead and do that, it should clean this all up a bit. thank you!
…s and clean up exported key
zackattack01
dismissed stale reviews from directionless, James-Pickett, and RebeccaMahany
via
383141f
ee/agent/reset.go
Outdated
| @@ -17,7 +17,7 @@ import ( | |||
| "github.com/kolide/launcher/pkg/traces" | |||
| ) | |||
|
|
|||
| type dbResetRecord struct { | |||
| type DBResetRecord struct { | |||
There was a problem hiding this comment.
I'm not totally sure why this is exported
There was a problem hiding this comment.
oh I might be able to un-export this one too after moving to using agent.GetResetRecords, will give that a try
RebeccaMahany
previously approved these changes
Mar 5, 2024
Co-authored-by: seph <seph@kolide.co>
Co-authored-by: seph <seph@kolide.co>
Co-authored-by: seph <seph@kolide.co>
directionless
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes rework the remote uninstall path to utilize the database reset record functionality (added to support remediation for hardware changes). Now, an uninstallation will first take a record of the previous database before resetting.
This also adds an Uninstall History checkup, which will read from the reset records key to report if any previous uninstallations/resets have been recorded.