Patch utf8 handling #481
Closed
Patch utf8 handling #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
reviewed
May 29, 2019
|
I'm not confident this will behave correctly, and there's one downvote. So I'm going to close this. |
|
Sounds like we probably want to revisit this. Probably only triggering repairs on utf8 errors |
Osquery sometimes mis-encodes utf8 data osquery/osquery#5288 This is a broad attempt to repair log files that exhibit that issue. This runs against the entire log file. Hopefully, there isn鈥檛 going to be a case where it misfires. Fixes: #445
directionless
force-pushed
the
seph/utf8
branch
from
8a025c1
to
e0cad41
Compare
|
In light of the additional conversation on #445, let's revisit this. This is a pretty heavy handed attempt to repair the data, and failing that, redact it, I don't have much for a test case though. |
|
This was fixed upstream, and I haven't seen this occur in ages. So I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Osquery sometimes mis-encodes utf8 data osquery/osquery#5288
This is a broad attempt to repair log files that exhibit that issue. This runs against the entire log file. Hopefully, there isn鈥檛 going to be a case where it misfires.
I'm not sure if this is great. On one hand, it fixes a bug in osquery. On the other hand, it introduces a discrepancy between osquery logs and launcher logs. Feel free to vote with 馃憤 or 馃憥. I'm going to let this sit a bit
Fixes: #445