Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon Linux AMI (aka amazon linux 1) #631

Merged
merged 6 commits into from Jul 30, 2020

Conversation

directionless
Copy link
Contributor

@directionless directionless commented Jul 27, 2020

Add support for Amazon Linux AMI. This distribution is rpm based, and uses a version of upstart that requires a slightly different configuration than ubuntu does.

To support this:

  • move the upstart.conf template into file assets
  • add some more variables to upstart config generation
  • plumb through an init flavor specific to amazon_linux_ami
  • add a logrotate configuration file

This has been tested on an ubuntu 14 and amazon linux ami host

Investigating amazon-ami linux, it has both upstart and sysV. But, it's
upstart seems to be slightly different. So, this plumbs in a new init
flavor for it

Because docker does not run init systems, this is easiest to test on ec2
Copy link
Contributor

@blaedj blaedj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this, but assuming that the init scripts etc behave properly, the go code changes lgtm.

@directionless directionless merged commit 3bdd07f into kolide:master Jul 30, 2020
@directionless directionless deleted the seph/amazon-linux branch July 30, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants