Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small code improvements #634

Merged
merged 5 commits into from Aug 3, 2020
Merged

Small code improvements #634

merged 5 commits into from Aug 3, 2020

Conversation

directionless
Copy link
Contributor

While working a bunch on MSI generation, I found several small things to cleanup:

  • Add an option to not cleanup the wix build directories. This aids in debugging MSI builds
  • Improve the method to find osqueryd binaries. This was hardcoded to an prior products install directory
  • Simplify the subcommand logic in main
  • Fix the makefile's code generation target

@directionless directionless merged commit 0461fd4 into kolide:master Aug 3, 2020
@directionless directionless deleted the seph/fixes-from-windows-land branch August 3, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaedj blaedj blaedj approved these changes

@jnog jnog Awaiting requested review from jnog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@directionless @blaedj