Record installer info in the windows registry #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaedj
approved these changes
Aug 6, 2020
For sure. I tested in this PR, but once merged we'll need to give it a solid going over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This records installer information in the windows registry. It is equivalent to the
installer-info.jsoninfo files left by the macOS and linux installers.Why the windows registry?
I spend a long while trying to do this in a similar looking json file. First, I experimented with wix's
XMLFileandXMLConfigelements. I was unable to get those to work reliably.I then spent awhile setting up a launcher
postinstallsubcommand that would create theinstaller-info.json. This worked, but calling it from wix felt a bit flakey. I had to useExeCommandand go through some weird quoting hassle. It did not feel stable.Then, I remembered that this is the sort of thing the windows registry is designed for. Both wix and osquery have straightforward support.