Auto Repair the local TUF repo #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen the local TUF repo get corrupt. This adds some simple local repairs when that happens. I've seen the TUF repo get corrupt. The cases I've seen are benign, and I believe due to some error handling in the [updater](https://github.com/kolide/updater). I think it's reasonable to detect and repair these. First, we're replacing the bad local copy with an expected good one from the compiled assets. Second, what else do we expect to happen?
blaedj
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen the local TUF repo get corrupt. This adds some simple local repairs when that happens.
I've seen the TUF repo get corrupt. The cases I've seen are benign, and I believe due to some error handling in the updater. I think it's reasonable to detect and repair these. First, we're replacing the bad local copy with an expected good one from the compiled assets. Second, what else do we expect to happen?
Testing this on my machine, it does recover from these states.