Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move windows updates to go #719

Merged
merged 15 commits into from
Mar 9, 2021
Merged

Move windows updates to go #719

merged 15 commits into from
Mar 9, 2021

Conversation

directionless
Copy link
Contributor

Move the windows update data from a powershell exec to go-ole.

This leverages the work in https://github.com/ceshihao/windowsupdate

@directionless directionless marked this pull request as ready for review March 9, 2021 01:12
blaedj
blaedj reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@blaedj blaedj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments. overall this looks pretty good, I suspect that there is the potential for bugs in the pkg/windows code, e.g. not matching the windows api types properly, but this seems to work well enough for our purposes.

pkg/osquery/tables/windowsupdate/windowsupdate.go Outdated Show resolved Hide resolved
pkg/osquery/tables/windowsupdate/windowsupdate.go Outdated Show resolved Hide resolved
blaedj
blaedj approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@blaedj blaedj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@directionless directionless merged commit e593b0f into kolide:master Mar 9, 2021
@directionless directionless deleted the seph/windowsupdate branch March 9, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaedj blaedj blaedj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@directionless @blaedj