Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code tidy #721

Merged
merged 11 commits into from
Mar 16, 2021
Merged

Code tidy #721

merged 11 commits into from
Mar 16, 2021

Conversation

directionless
Copy link
Contributor

Batching several small changes

  1. Remove CI builder, which is now too new for go 1.13
  2. Use the comshim library for wmi
  3. Update dataflatten to accept a logger, and apply the info filter internally
  4. Update dataflatten callers to have fewer if blocks (dataflatten duplicates that internally)

@directionless directionless marked this pull request as ready for review March 10, 2021 02:34
blaedj
blaedj approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@blaedj blaedj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/dataflatten/flatten.go Show resolved Hide resolved
@directionless directionless merged commit e70215d into kolide:master Mar 16, 2021
@directionless directionless deleted the seph/small-cleanup branch March 16, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaedj blaedj blaedj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@directionless @blaedj