-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and fix improper file ownership on launch #722
Detect and fix improper file ownership on launch #722
Conversation
This commit: - detects a subset of what osquery will consider improper file perms/ownership on the extension binary - tries to fix those errors We could and perhaps should apply this to the entire root directory, and this doesn't yet work on windows.
This reverts commit 7b60a5d. osqueryd is not in usr/local/, so is not likely to have perms conflicting with homebrew.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and appears to work as advertised. Yay!
Digging at a test case, I don't see a homebrew provided command or docs that creates this error. But chown $USER
does cause this problem, and it shows up in various suggestions
that's the script I used (or close to it) to test this out. |
This commit:
perms/ownership on the extension binary
We could and perhaps should apply this to the entire root directory,
and this doesn't yet work on windows.