Disable CGO on windows #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a hunch cgo on windows is causing _big_ issues. Disable it.
blaedj
approved these changes
Nov 23, 2021
blaedj
reviewed
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On windows, launcher seems to use a lot of disk space.
It's not wholly clear to me why.
vmmapshows that it's all in the heap. Notably, golang/go#22439 describes this problem pretty well. The discussion there is that a confluence of windows memory management, and go stack allocations end up in go requesting far more memory than intended, and that this is only a problem because windows locks it in memory (as opposed to treating it as virtual addresses)The fix described in that PR, is a revert in go that changes the stack allocation to be smaller. But when compiling with
CGOit's still large.Windows does not need cgo -- Linux does, and I simply added it everywhere. So, on a hunch, let's disable cgo on windows.