Create a local log, to a known path, with regular log messages #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
changed the title
directionless
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When debugging with launcher users, it is often very hard to get the appropriate logs. This is because they logs go to different places on different platforms. (And on windows, they're especially weird)
Solution
This replaces the local debug log file option (from #639) with an always-enabled, rolling, log file. The initial implementation suffered from a couple of issues. First, it required being explicitly enabled. Second, it didn't rotate.
This also adds a periodic log message to aid in finding what host the logs are from. This checkpoint message is an initial PoC, and is expected to evolve over time.