Generalized parser and table for cryptographic materials (eg: certificates) #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
pkg/keyidentifier
, we've long had the ability to parse private keys. But we've often wanted to add certificates to that. Unfortunately that library and associated table hardcode several assumptions about the shape of the resultant data.Thus,
pkg/cryptoinfo
and the associatedkolide_cryptoinfo
. This is designed to return nested data, suitable for being handed to dataflatten.Right now, it only parses certificates, though it should handle both common formats (DER and PEM). I think it has the bones to grow into handling all other keys as needed. We could replace
pkg/keyidentifier
with it.For example: