Add p12 parsing to pkg/cryptoinfo
#792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaedj
reviewed
Feb 10, 2022
Co-authored-by: blaedj <blaedj@users.noreply.github.com>
levicole
reviewed
Feb 10, 2022
blaedj
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in p12 parsing to
pkg/cryptoinfo.In doing this, I discovered that a bunch of ssl formats are ASN, and thus it is not possible to identify these files by their leading bytes. Instead, this moves to a simply attempting to parse, and moving on if it's wrong.
Note that this does expose a
passphaseoption. One should be cautious using it, as it may cause the passphrase to be logged.