Implementation for #16, Automatic Headers/Footers #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a view is not provided by the data source, but a title is, it will be used to generate a default view.
Fixed a typo as well
|
Just curious, what do the automatic implementations look like? |
kolinkrewinkel
added a commit
that referenced
this pull request
Dec 17, 2011
Implementation for #16, Automatic Headers/Footers
|
Pretty much like the demo ones you wrote. I spruced up the colors a tiny bit, but basically the same. Here's a screenshot: |
|
I think at some point, it may be beneficial to try to make the defaults look like |
|
Okay, that looks nice. Later on I'll change them to Apple's default style. |
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
-gridView:titleForHeaderInSection:and-gridView:titleForFooterInSection:to<KKGridViewDataSource>. These should behave as expected.Consumers may continue to provide their own views in the usual way if they desire to do so.