Require bugfix when the attr is not specified

koliseoapi · Jul 7, 2020 · 3ca5eff · 3ca5eff
1 parent 3d9c0bf
commit 3ca5eff
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/src/core/ValidationActions.ts b/src/core/ValidationActions.ts
@@ -1,4 +1,4 @@
-import { isNullOrUndefined, isBlank, isFalse } from "./utils";
+import { isNullOrUndefined, isBlank, isFalse, hasProperty } from "./utils";
 import { BoundComponentProps } from "../components/InputElements";
 
 let re_weburl: RegExp;
@@ -39,7 +39,7 @@ export const ValidationActions = {
     value: any,
     props: BoundComponentProps
   ): Promise<ValidationResult> {
-    if (isBlank(value) && !isFalse(props.required)) {
+    if (isBlank(value) && hasProperty(props, 'required') && !isFalse(props.required)) {
       return "required";
     }
   },
@@ -48,7 +48,7 @@ export const ValidationActions = {
     value: number,
     props: BoundComponentProps
   ): Promise<ValidationResult> {
-    if (isNullOrUndefined(value) && !isFalse(props.required)) {
+    if (isNullOrUndefined(value) && hasProperty(props, 'required') && !isFalse(props.required)) {
       return "required";
     }
   },

diff --git a/src/core/utils.ts b/src/core/utils.ts
@@ -9,6 +9,10 @@ export function isFalse(value: boolean): boolean {
   return value === false;
 }
 
+export function hasProperty(obj: object, property: string): boolean {
+  return property in obj;
+}
+
 /**
  * Sets a nested property such as "foo.bar.baz", initializing intermediate nodes if needed
  */

diff --git a/test/ValidationActionsTest.ts b/test/ValidationActionsTest.ts
@@ -16,6 +16,13 @@ describe("ValidationActions", function () {
     await failRequired(false);
     await failRequired("");
     await failRequired(" \t");
+    async function worksNotSpecifyingRequiredProp(value: any) {
+      expect(await ValidationActions.required(value, { })).toBeUndefined();
+    }
+    await worksNotSpecifyingRequiredProp(null);
+    await worksNotSpecifyingRequiredProp(undefined);
+    await worksNotSpecifyingRequiredProp(false);
+    await worksNotSpecifyingRequiredProp("foo");
   });
 
   it("number.required should reject null and undefined, but acept 0", async function () {
@@ -31,6 +38,13 @@ describe("ValidationActions", function () {
     ).toBeUndefined();
     await failRequired(null);
     await failRequired(undefined);
+    async function worksNotSpecifyingRequiredProp(value: any) {
+      expect(await ValidationActions.number_required(value, { })).toBeUndefined();
+    }
+    await worksNotSpecifyingRequiredProp(null);
+    await worksNotSpecifyingRequiredProp(undefined);
+    await worksNotSpecifyingRequiredProp(false);
+    await worksNotSpecifyingRequiredProp(0);
   });
 
   it("Number min value", async function () {