use JSON library instead. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siong1987 I would love to accept it but I think you first have to add multi_json as a dependency on gemspec :) |
|
@vasilakisfil if you look at the code, i am currently using the default |
vasilakisfil
added a commit
that referenced
this pull request
Apr 26, 2015
use JSON library instead.
|
My bad :/ Took it wrong.. I guess it was way too early and Sunday to review a pull request ^_^ |
|
@vasilakisfil haha. no worries. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now, we need to depend on "multi_json" gem in order to use this library (which isn't declared in the gemspec as dependency).
default
jsonlibrary is good enough and that's why i am replacingmulti_jsonwith it.