Increase test coverage

kolmafia · Mar 12, 2024 · 89ae69d · 89ae69d
1 parent 306d7f1
commit 89ae69d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/net/sourceforge/kolmafia/session/LocketManager.java b/src/net/sourceforge/kolmafia/session/LocketManager.java
@@ -186,9 +186,11 @@ public static void decorateMonsterDropdown(final StringBuffer buffer) {
       int monsterId = Integer.valueOf(matcher.group(1));
       String name = matcher.group(2);
       MonsterData monster = MonsterDatabase.findMonsterById(monsterId);
-      String monsterName = monster.getName();
-      if (monster != null && !name.equals(monsterName)) {
-        buffer.replace(matcher.start(2), matcher.end(2), monsterName);
+      if (monster != null) {
+        String monsterName = monster.getName();
+        if (!name.equals(monsterName)) {
+          buffer.replace(matcher.start(2), matcher.end(2), monsterName);
+        }
       }
     }
   }

diff --git a/test/net/sourceforge/kolmafia/session/LocketManagerTest.java b/test/net/sourceforge/kolmafia/session/LocketManagerTest.java
@@ -83,7 +83,8 @@ public void canDecorateAmbiguousMonsters() {
     assertTrue(buffer.indexOf("<option value=\"553\" >spider gremlin</option>") != -1);
     assertTrue(buffer.indexOf("<option value=\"551\" >vegetable gremlin</option>") != -1);
 
-    LocketManager.decorateMonsterDropdown(buffer);
+    // Ultimately calls LocketManager.decorateMonsterDropdown(buffer);
+    ChoiceAdventures.decorateChoice(1463, buffer, true);
 
     assertTrue(buffer.indexOf("<option value=\"549\" >batwinged gremlin (tool)</option>") != -1);
     assertTrue(buffer.indexOf("<option value=\"547\" >erudite gremlin (tool)</option>") != -1);