Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show "empty" for folders 4 and 5 at valhalla #1007

Merged
merged 3 commits into from
Aug 21, 2022

Conversation

midgleyc
Copy link
Member

No description provided.

@midgleyc midgleyc requested a review from a team as a code owner August 21, 2022 13:09
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #1007 (dd5d347) into main (9e832f4) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1007      +/-   ##
============================================
- Coverage     27.76%   27.75%   -0.01%     
+ Complexity    13201    13195       -6     
============================================
  Files          1030     1030              
  Lines        160493   160494       +1     
  Branches      35240    35240              
============================================
- Hits          44556    44545      -11     
- Misses       107660   107672      +12     
  Partials       8277     8277              
Impacted Files Coverage Δ
.../sourceforge/kolmafia/webui/ValhallaDecorator.java 0.00% <0.00%> (ø)
...sourceforge/kolmafia/session/EquipmentManager.java 34.22% <100.00%> (+0.05%) ⬆️
...forge/kolmafia/persistence/ConcoctionDatabase.java 46.15% <0.00%> (-0.59%) ⬇️
...et/sourceforge/kolmafia/objectpool/Concoction.java 62.45% <0.00%> (-0.55%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 51.66% <0.00%> (-0.09%) ⬇️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e832f4...dd5d347. Read the comment docs.

Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gausie gausie enabled auto-merge (squash) August 21, 2022 17:41
@gausie gausie merged commit c00414f into kolmafia:main Aug 21, 2022
@midgleyc midgleyc deleted the fix-equipment-stuff branch August 21, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants