Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle backup camera choice unavailable #1025

Merged
merged 2 commits into from Aug 26, 2022

Conversation

libraryaddict
Copy link
Contributor

Using backupcamera ml while ML is already selected, will leave mafia in a state where it thinks it's still handling a choice.

Pushed a failing test to prove it be a thing. Fix incoming.

@libraryaddict libraryaddict requested a review from a team as a code owner August 25, 2022 17:14
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1025 (e7583c5) into main (8af45d8) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1025   +/-   ##
=========================================
  Coverage     28.51%   28.52%           
- Complexity    13589    13595    +6     
=========================================
  Files          1031     1031           
  Lines        160598   160600    +2     
  Branches      35285    35286    +1     
=========================================
+ Hits          45801    45811   +10     
+ Misses       106360   106347   -13     
- Partials       8437     8442    +5     
Impacted Files Coverage Δ
...e/kolmafia/textui/command/BackupCameraCommand.java 92.85% <50.00%> (-3.30%) ⬇️
...forge/kolmafia/persistence/ConcoctionDatabase.java 46.85% <0.00%> (-0.06%) ⬇️
...et/sourceforge/kolmafia/session/ChoiceManager.java 16.22% <0.00%> (+0.10%) ⬆️
...et/sourceforge/kolmafia/session/ChoiceControl.java 6.51% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af45d8...e7583c5. Read the comment docs.

@midgleyc midgleyc merged commit 77a3b91 into kolmafia:main Aug 26, 2022
@libraryaddict libraryaddict deleted the backup_choices branch August 29, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants