Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mistake other PvP gains for a goth kid charge #1049

Merged
merged 1 commit into from Sep 2, 2022

Conversation

@gausie gausie requested a review from a team as a code owner September 2, 2022 14:41
Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gausie gausie enabled auto-merge (squash) September 2, 2022 14:47
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1049 (d857aa5) into main (391bb8a) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1049   +/-   ##
=========================================
  Coverage     29.01%   29.02%           
- Complexity    13908    13914    +6     
=========================================
  Files          1035     1035           
  Lines        160809   160812    +3     
  Branches      35207    35208    +1     
=========================================
+ Hits          46665    46681   +16     
+ Misses       105645   105635   -10     
+ Partials       8499     8496    -3     
Impacted Files Coverage Δ
...net/sourceforge/kolmafia/request/FightRequest.java 30.62% <75.00%> (+0.22%) ⬆️
...et/sourceforge/kolmafia/scripts/ScriptManager.java 54.90% <0.00%> (-3.93%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 60.62% <0.00%> (-0.26%) ⬇️
...forge/kolmafia/persistence/ConcoctionDatabase.java 46.72% <0.00%> (-0.06%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 55.79% <0.00%> (+0.08%) ⬆️
.../sourceforge/kolmafia/session/ResultProcessor.java 25.13% <0.00%> (+0.13%) ⬆️
src/net/sourceforge/kolmafia/AdventureResult.java 45.33% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391bb8a...d857aa5. Read the comment docs.

@gausie gausie merged commit 2d20861 into main Sep 2, 2022
@gausie gausie deleted the goth-kid-pvp-match branch September 2, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants