Buzzed on Distillate #1060
Merged
Buzzed on Distillate #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods easier. This has a lot more that could be done
gausie
force-pushed
the
buzzed-on-distillate
branch
from
a586365
to
fef5878
Compare
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
============================================
+ Coverage 29.05% 29.07% +0.01%
- Complexity 13948 13956 +8
============================================
Files 1035 1035
Lines 160822 160807 -15
Branches 35200 35195 -5
============================================
+ Hits 46733 46750 +17
+ Misses 105595 105561 -34
- Partials 8494 8496 +2
Continue to review full report at Codecov.
|
midgleyc
previously approved these changes
Sep 7, 2022
Yes but I'll add a test for that now |
…, as well as testing the rest of gaining Entauntauned working correctly
…nto buzzed-on-distillate
…uences.txt and then just trigger a visit to parse it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks the current and next Buzzed on Distillate effect mods, as well as making it possible to track whole effect mods through consequences.txt
There is a bigger refactor to consequences.txt that should be done in my mind - make it o that each consequence knows how it can be checked and if it should be checked (effects that you have, items that you have or have equipped, skills you know etc) and then a single fn to check them all if necessary. Instead we have loads of repeated "check" functions. Anyway, that will come another time.