Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate forbidden stores in relay page #1088

Merged
merged 3 commits into from Sep 17, 2022

Conversation

libraryaddict
Copy link
Contributor

@libraryaddict libraryaddict commented Sep 16, 2022

@libraryaddict libraryaddict requested a review from a team as a code owner September 16, 2022 22:22
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1088 (39fe1e5) into main (29d47f2) will increase coverage by 0.00%.
The diff coverage is 65.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1088   +/-   ##
=========================================
  Coverage     29.62%   29.62%           
- Complexity    14306    14308    +2     
=========================================
  Files          1036     1036           
  Lines        160973   160993   +20     
  Branches      35162    35165    +3     
=========================================
+ Hits          47690    47700   +10     
- Misses       104723   104733   +10     
  Partials       8560     8560           
Impacted Files Coverage Δ
...ourceforge/kolmafia/request/MallSearchRequest.java 57.54% <65.00%> (+0.45%) ⬆️
...forge/kolmafia/textui/langserver/FilesMonitor.java 76.92% <0.00%> (-1.29%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 20.00% <0.00%> (-0.48%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 56.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d47f2...39fe1e5. Read the comment docs.

@libraryaddict
Copy link
Contributor Author

Should it be calling "preference" by "property" instead?

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@midgleyc
Copy link
Member

And no, I think externally it's all "preference" (e.g. prefref).

@midgleyc midgleyc enabled auto-merge (squash) September 17, 2022 07:59
@midgleyc midgleyc merged commit 8f37621 into kolmafia:main Sep 17, 2022
@libraryaddict libraryaddict deleted the relay-forbidden-stores branch February 11, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants