fix: limit_mode for none must be empty

[midgleyc]

#1084 broke ChIT, which assumes the result of limit_mode for no limit mode must be "", but it is instead "0".

[gausie]

I really think this isn't right. We should keep it as 0 - the official key we get from KoL servers - and add a getASHName instance function to LimitMode that returns "" when the enum is LimitMode.NONE, and use that in limit_mode().

[codecov]

Codecov Report

Merging #1089 (f8eddc9) into main (acdde48) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1089      +/-   ##
============================================
- Coverage     29.65%   29.65%   -0.01%     
  Complexity    14350    14350              
============================================
  Files          1036     1036              
  Lines        160939   160943       +4     
  Branches      35122    35123       +1     
============================================
- Hits          47729    47728       -1     
- Misses       104649   104652       +3     
- Partials       8561     8563       +2     

Impacted Files	Coverage Δ
.../sourceforge/kolmafia/request/CharPaneRequest.java	49.06% <33.33%> (+0.29%)	⬆️
...rc/net/sourceforge/kolmafia/session/LimitMode.java	70.78% <95.23%> (-0.48%)	⬇️
...sourceforge/kolmafia/textui/langserver/Script.java	81.91% <0.00%> (-3.20%)	⬇️
src/net/sourceforge/kolmafia/FamiliarData.java	53.30% <0.00%> (-0.31%)	⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java	56.26% <0.00%> (-0.09%)	⬇️
...sourceforge/kolmafia/session/EquipmentManager.java	37.07% <0.00%> (+0.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdde48...f8eddc9. Read the comment docs.

[midgleyc]

"0" isn't the key, though. The key is an integer -- 0.

I'd rather change the API code to something like

    Object lmo = JSON.get("limitmode");
    if (lmo instanceof Integer && lmo.equals(0)) {
      KoLCharacter.setLimitMode(LimitMode.NONE);
    } else {
      KoLCharacter.setLimitMode(lmo.toString());
    }

and add UNKNOWN for an unknown string.

[gausie]

"0" isn't the key, though. The key is an integer -- 0.

I'd rather change the API code to something like

    Object lmo = JSON.get("limitmode");
    if (lmo instanceof Integer && lmo.equals(0)) {
      KoLCharacter.setLimitMode(LimitMode.NONE);
    } else {
      KoLCharacter.setLimitMode(lmo.toString());
    }

and add UNKNOWN for an unknown string.

This works with me

[gausie]

We should probably instanceof string check here and error out otherwise. And add a coverage test to this slice of the code too, why not

[midgleyc]

aye, will merge here and follow-up.