Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Galaktic, MeatSmith, and Armorer quests and Exploathing prism warning #1119

Merged
merged 2 commits into from Sep 25, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Sep 24, 2022

What it says.

  1. I got HTML for starting Doc Galaktik's quest and opening The Overgrown Lot.
    I un-disabled the test for that and made it use said HTML.
  2. I got HTML for starting the Meatsmith's quest and opening The Skeleton Store.
    I un-disabled the test for that and made it use said HTML.
  3. I got HTML for starting the Armorer's quest and opening Madness Bakery.
    I un-disabled the test for that and made it use said HTML.
  4. I added tests for the prism warning when in Kingdom of Exploathing, based on those for Dinocore.
  5. I made a Nested class for the three prism warning Nested classes.
  6. I put Mohawk Wig, Machete, and Survival Knife tests in their own Nested classes as well.
    Those tests should be split into multiple tests and modernized to use cleanups.
    Maybe later.
  7. I also made all the tests in KoLAdventureValidationTest a little more compact via:
      var builder = new FakeHttpClientBuilder();
      var client = builder.client;

and using "client" everywhere instead of "builder.client".
8) I figured out why the council wasn't recognizing the early quests in DInocore: the property names were wrong.
For example, instead of quesL02Larva, we had quest02Larva

@Veracity0 Veracity0 requested a review from a team as a code owner September 24, 2022 19:23
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #1119 (9f635ed) into main (1db3482) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1119      +/-   ##
============================================
+ Coverage     30.26%   30.33%   +0.07%     
- Complexity    14672    14774     +102     
============================================
  Files          1037     1037              
  Lines        161375   161375              
  Branches      35170    35170              
============================================
+ Hits          48838    48957     +119     
+ Misses       103790   103576     -214     
- Partials       8747     8842      +95     
Impacted Files Coverage Δ
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️
...net/sourceforge/kolmafia/session/OceanManager.java 69.58% <0.00%> (-0.52%) ⬇️
...forge/kolmafia/persistence/ConcoctionDatabase.java 48.59% <0.00%> (+0.05%) ⬆️
...et/sourceforge/kolmafia/session/ChoiceControl.java 7.20% <0.00%> (+0.13%) ⬆️
...ourceforge/kolmafia/request/CreateItemRequest.java 42.81% <0.00%> (+0.30%) ⬆️
...urceforge/kolmafia/session/ResponseTextParser.java 25.33% <0.00%> (+0.37%) ⬆️
...net/sourceforge/kolmafia/request/RelayRequest.java 22.45% <0.00%> (+0.45%) ⬆️
src/net/sourceforge/kolmafia/CoinmasterData.java 40.33% <0.00%> (+0.55%) ⬆️
src/net/sourceforge/kolmafia/RequestLogger.java 26.91% <0.00%> (+0.62%) ⬆️
...ceforge/kolmafia/persistence/NPCStoreDatabase.java 47.82% <0.00%> (+0.66%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db3482...9f635ed. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants