Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes #1133

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Miscellaneous fixes #1133

merged 4 commits into from
Sep 30, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Sep 29, 2022

  1. Mushroom Garden in KoE is inaccessable with a new failure message
  2. Adventuring in The Lower Chambers might take 1 turn or it might take 7
  3. When purchasing from NPCs, prefer Travoltan trousers over designer sweat pants
  4. When using trousers for NPC purchases, allow retrieving the item, rather than requiring it to be in inventory
  5. When suiting up for NPC purchases, use an outfit checkpoint
  6. Allow counter warnings to fire when going to lower chamber from the pyramid control panel
  7. prepareForAdventure will talk to Bart to open the tavern cellar

@Veracity0 Veracity0 requested a review from a team as a code owner September 29, 2022 20:00
@Veracity0 Veracity0 marked this pull request as draft September 29, 2022 20:03
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1133 (715bfa6) into main (cb03c01) will increase coverage by 0.05%.
The diff coverage is 65.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1133      +/-   ##
============================================
+ Coverage     30.36%   30.41%   +0.05%     
- Complexity    14817    14851      +34     
============================================
  Files          1037     1037              
  Lines        161429   161464      +35     
  Branches      35183    35194      +11     
============================================
+ Hits          49013    49112      +99     
+ Misses       103573   103482      -91     
- Partials       8843     8870      +27     
Impacted Files Coverage Δ
.../sourceforge/kolmafia/request/PurchaseRequest.java 24.36% <0.00%> (-0.42%) ⬇️
...net/sourceforge/kolmafia/request/RelayRequest.java 23.67% <ø> (+1.23%) ⬆️
...net/sourceforge/kolmafia/request/PlaceRequest.java 16.60% <27.27%> (+0.21%) ⬆️
...et/sourceforge/kolmafia/session/ChoiceControl.java 7.26% <75.00%> (+0.06%) ⬆️
.../net/sourceforge/kolmafia/session/TurnCounter.java 46.10% <75.00%> (+4.17%) ⬆️
src/net/sourceforge/kolmafia/KoLAdventure.java 58.72% <100.00%> (+0.14%) ⬆️
...sourceforge/kolmafia/request/AdventureRequest.java 39.87% <100.00%> (+0.19%) ⬆️
...urceforge/kolmafia/request/NPCPurchaseRequest.java 15.42% <100.00%> (+0.12%) ⬆️
...t/sourceforge/kolmafia/request/PyramidRequest.java 14.28% <100.00%> (+14.28%) ⬆️
...et/sourceforge/kolmafia/session/ChoiceManager.java 24.08% <100.00%> (+0.23%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb03c01...715bfa6. Read the comment docs.

@Veracity0 Veracity0 marked this pull request as ready for review September 29, 2022 21:36
@Veracity0 Veracity0 enabled auto-merge (squash) September 30, 2022 00:11
@Veracity0 Veracity0 merged commit 3134a34 into main Sep 30, 2022
@Veracity0 Veracity0 deleted the misc-tweaks branch September 30, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants