refactor: use types internally for environment and difflevel

[midgleyc]

No description provided.

[codecov]

Codecov Report

Merging #1179 (d758db6) into main (e632720) will increase coverage by 0.02%.
The diff coverage is 71.69%.

❗ Current head d758db6 differs from pull request most recent head 81bca3b. Consider uploading reports for the commit 81bca3b to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1179      +/-   ##
============================================
+ Coverage     30.94%   30.96%   +0.02%     
- Complexity    15192    15201       +9     
============================================
  Files          1038     1038              
  Lines        161578   161608      +30     
  Branches      35096    35099       +3     
============================================
+ Hits          49997    50041      +44     
+ Misses       102660   102647      -13     
+ Partials       8921     8920       -1     

Impacted Files	Coverage Δ
src/net/sourceforge/kolmafia/AreaCombatData.java	17.35% <0.00%> (ø)
src/net/sourceforge/kolmafia/KoLAdventure.java	59.38% <ø> (ø)
...ge/kolmafia/textui/parsetree/ProxyRecordValue.java	53.02% <0.00%> (ø)
...net/sourceforge/kolmafia/request/FightRequest.java	32.01% <57.14%> (+0.23%)	⬆️
...eforge/kolmafia/persistence/AdventureDatabase.java	59.73% <78.94%> (+1.45%)	⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java	57.91% <100.00%> (ø)
src/net/sourceforge/kolmafia/Modifiers.java	62.99% <100.00%> (ø)
.../net/sourceforge/kolmafia/maximizer/Evaluator.java	60.23% <100.00%> (ø)
...sourceforge/kolmafia/request/AdventureRequest.java	42.99% <100.00%> (ø)
...sourceforge/kolmafia/session/EquipmentManager.java	37.26% <0.00%> (+0.16%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e632720...81bca3b. Read the comment docs.

[jaadams5]

No new tests? ;-)

[midgleyc]

It looks like the only uncovered areas are:

• AreaCombatData.toString(), but I can't see where this is called (outside of RelayRequest's "safety") or what it should do
• Two error branches that shouldn't be called
• Gibberer adventure increment, for which I'd want a debug log from somebody with a Gibberer.

[Veracity0]

I have a Gibberererer.

I assume you want the "time slows down message" which supposedly gives an extra rollover adventure. Supposedly "like a wild hare".

Do you want a wild hare message, too?

I'm out of turns today, but tomorrow is another day.

[midgleyc]

Yes please: both would be good for tests.

[gausie]

Love it, thank you. I suppose I should have waited for the above comments to be resolved, but still.

[midgleyc]

I'll do the tests once I get the HTML, but I agree this can go in as-is.

[midgleyc]

made it in under the wire, V

I'll get the tests done now

[Veracity0]

I just uploaded .txt files for both the hare and gibberer.
txt, not html, so you can see which requests were submitted.
Obviously, you will extract the html. :)

[midgleyc]

you probably want to relogin, too: you've given enough info for somebody to impersonate you, going by https://kolmafia.us/threads/replace-pwd-hashes-in-debug-log-with-generic-string.28127/ (the session id + cors header + user agent)

[Veracity0]

I logged out and came downstairs to have breakfast.

[Veracity0]

And do feel free to delete the .txt once you have extracted the html and request. :)