Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffLevels for Cola Wars zones #1211

Merged
merged 2 commits into from Oct 24, 2022
Merged

DiffLevels for Cola Wars zones #1211

merged 2 commits into from Oct 24, 2022

Conversation

Veracity0
Copy link
Contributor

This was tricky. The Rift is only open for levels 4 and 5, and you have to have completed the first part of the Wizard of Ego quest to even get it. I timed my first two Autumn-aton tasks to pick up the two upgrades that grant an additional 11-turn mission, so that when I eventually did open the rift, I could get two 11-turn and one 22-turn mission while the Rift was still open.

I did the "No Uniform" zone first and got an Autumn Debris Shield - the mid-outdoor reward.
The Cloaca Uniform mission yielded an autumn leaf - the low-outdoor reward.
The Dyspepsi Uniform missionn gave a autumn years wisdom - the high-underground reward.

I believe both of those had to also be mid-outdoor zones, but since the equipment had already been granted, it was replaced with a consumable item.

@Veracity0 Veracity0 requested a review from a team as a code owner October 24, 2022 19:31
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1211 (9ba894f) into main (5d18601) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9ba894f differs from pull request most recent head c06d0be. Consider uploading reports for the commit c06d0be to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1211      +/-   ##
============================================
- Coverage     31.57%   31.56%   -0.01%     
  Complexity    15457    15457              
============================================
  Files          1038     1038              
  Lines        161954   161954              
  Branches      35163    35163              
============================================
- Hits          51134    51128       -6     
- Misses       101765   101772       +7     
+ Partials       9055     9054       -1     
Impacted Files Coverage Δ
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 79.48% <0.00%> (-1.29%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 20.00% <0.00%> (-0.48%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 57.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d18601...c06d0be. Read the comment docs.

@jaadams5 jaadams5 merged commit 644260d into main Oct 24, 2022
@jaadams5 jaadams5 deleted the cola-diff branch October 24, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants