fix: NPE on invalid locations #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=========================================
Coverage 31.64% 31.64%
- Complexity 15506 15511 +5
=========================================
Files 1038 1038
Lines 162082 162083 +1
Branches 35180 35181 +1
=========================================
+ Hits 51285 51294 +9
+ Misses 101726 101725 -1
+ Partials 9071 9064 -7
Continue to review full report at Codecov.
|
Veracity0
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1216.
To ensure the test continues testing the right thing (invalid locations don't break the command), I've added "Gausie's Grotto" to the test list as number 13.