Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups, tests, and small features. #1225

Merged
merged 10 commits into from Nov 4, 2022
Merged

Various cleanups, tests, and small features. #1225

merged 10 commits into from Nov 4, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Nov 3, 2022

  1. I noticed that the new IOTM often appeared with an extra space in front of its item name. In Mr. Store, for example.
    I looked at all the places when we extract items names from KoL pages where we check the name against the expected name given the itemId. I made them all trim() the extracted name.
  2. There were many places where we looked up itemId from descId and, if not found, registered a new item from the descId.
    I added ItemDatabase.lookUpItemIdFromDescription, which will lookup the item using the descid and will register a new item if not found. In either case, return the itemId.
  3. There were several examples of old code which declared that they could not register new items given just a descId, "since they didn't have itemId". Old, I say, because we have long had the ability to register new items using just the description. I made those places use the new method to look up and register if required.
  4. I added tracking the Grimstone hare game in "hareMillisecondsSaved" incremented after each fight. KoL logs the final time as something like "29:58.162" - which is to say, 30 minutes - accumulated milliseconds.
  5. Pandamonium is open only when you visit it. I have saved HTML for doing that.
    canAdventure() allows Panadmonium zones if Azazel quest is started, Friars is finished, or you have the ritual items.
    prepareForAdventure will run the ritual, if needed, and start Azazel, if needed.
  6. Unit tests for KoLAdventure.canAdventure() with the 5 grimstone zones.
  7. Legendary recipes and foods, courtesy of reverkiller

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1225 (c67dbce) into main (728dbc4) will increase coverage by 0.02%.
The diff coverage is 53.96%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1225      +/-   ##
============================================
+ Coverage     31.72%   31.74%   +0.02%     
- Complexity    15579    15601      +22     
============================================
  Files          1039     1039              
  Lines        162193   162206      +13     
  Branches      35201    35207       +6     
============================================
+ Hits          51448    51488      +40     
+ Misses       101667   101630      -37     
- Partials       9078     9088      +10     
Impacted Files Coverage Δ
...eforge/kolmafia/persistence/EquipmentDatabase.java 71.81% <ø> (+0.47%) ⬆️
...sourceforge/kolmafia/request/ClanStashRequest.java 31.89% <0.00%> (ø)
...ourceforge/kolmafia/request/GameShoppeRequest.java 23.28% <0.00%> (ø)
...rceforge/kolmafia/request/MicroBreweryRequest.java 5.50% <0.00%> (ø)
...t/sourceforge/kolmafia/request/PhineasRequest.java 16.36% <0.00%> (ø)
...forge/kolmafia/request/SpinMasterLatheRequest.java 44.55% <0.00%> (ø)
...rge/kolmafia/request/TerrifiedEagleInnRequest.java 30.90% <0.00%> (ø)
...ceforge/kolmafia/request/TicketCounterRequest.java 36.00% <0.00%> (ø)
...forge/kolmafia/request/TravelingTraderRequest.java 14.94% <0.00%> (+0.49%) ⬆️
...sourceforge/kolmafia/session/GrimstoneManager.java 29.47% <0.00%> (-0.32%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728dbc4...c67dbce. Read the comment docs.

@Veracity0 Veracity0 marked this pull request as ready for review November 4, 2022 15:47
@Veracity0 Veracity0 requested a review from a team as a code owner November 4, 2022 15:47
src/data/fullness.txt Outdated Show resolved Hide resolved
src/data/fullness.txt Outdated Show resolved Hide resolved
@Veracity0 Veracity0 merged commit 35493b7 into main Nov 4, 2022
@Veracity0 Veracity0 deleted the validation branch November 4, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants