New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various cleanups, tests, and small features. #1225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
============================================
+ Coverage 31.72% 31.74% +0.02%
- Complexity 15579 15601 +22
============================================
Files 1039 1039
Lines 162193 162206 +13
Branches 35201 35207 +6
============================================
+ Hits 51448 51488 +40
+ Misses 101667 101630 -37
- Partials 9078 9088 +10
Continue to review full report at Codecov.
|
midgleyc
requested changes
Nov 4, 2022
midgleyc
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at all the places when we extract items names from KoL pages where we check the name against the expected name given the itemId. I made them all trim() the extracted name.
I added ItemDatabase.lookUpItemIdFromDescription, which will lookup the item using the descid and will register a new item if not found. In either case, return the itemId.
canAdventure() allows Panadmonium zones if Azazel quest is started, Friars is finished, or you have the ritual items.
prepareForAdventure will run the ritual, if needed, and start Azazel, if needed.