Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appearance_rates for jungles of ancient loathing & seaside megapolis #1233

Merged
merged 1 commit into from Nov 6, 2022

Conversation

Rinn
Copy link
Contributor

@Rinn Rinn commented Nov 6, 2022

I don't have the page html to write tests for the quest progress but I wrote tests for the encounter rates.

@Rinn Rinn requested a review from a team as a code owner November 6, 2022 05:40
@Rinn Rinn changed the title Fix available monsters for jungle & seaside megapolis Fix appearance_rates for jungles of ancient loathing & seaside megapolis Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1233 (eabe9be) into main (9ab21fa) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1233   +/-   ##
=========================================
  Coverage     31.91%   31.91%           
- Complexity    15709    15719   +10     
=========================================
  Files          1040     1040           
  Lines        162296   162311   +15     
  Branches      35227    35235    +8     
=========================================
+ Hits          51795    51807   +12     
- Misses       101347   101349    +2     
- Partials       9154     9155    +1     
Impacted Files Coverage Δ
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
...et/sourceforge/kolmafia/session/ChoiceControl.java 7.93% <0.00%> (-0.02%) ⬇️
src/net/sourceforge/kolmafia/AreaCombatData.java 18.34% <100.00%> (+0.98%) ⬆️
...ourceforge/kolmafia/persistence/QuestDatabase.java 40.19% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab21fa...eabe9be. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could Cleanupsify the tests (and split them out), but the AreaCombatTestData is already resetting the character between tests so no harm as is I think.

Thanks!

Add quest steps for Future quest
@Rinn Rinn merged commit cfa1e6b into main Nov 6, 2022
@Rinn Rinn deleted the agua-monsters branch November 6, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants