Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queue being added to without reason when pondering #1238

Merged
merged 4 commits into from Nov 8, 2022

Conversation

libraryaddict
Copy link
Contributor

No description provided.

@libraryaddict libraryaddict requested a review from a team as a code owner November 7, 2022 00:22
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1238 (1583247) into main (61e934a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1238   +/-   ##
=========================================
  Coverage     32.22%   32.22%           
  Complexity    15837    15837           
=========================================
  Files          1041     1041           
  Lines        162348   162348           
  Branches      35243    35243           
=========================================
+ Hits          52320    52322    +2     
+ Misses       100783   100779    -4     
- Partials       9245     9247    +2     
Impacted Files Coverage Δ
...urceforge/kolmafia/session/CrystalBallManager.java 77.12% <100.00%> (ø)
...et/sourceforge/kolmafia/scripts/ScriptManager.java 67.16% <0.00%> (-2.99%) ⬇️
src/net/sourceforge/kolmafia/StaticEntity.java 21.78% <0.00%> (-0.28%) ⬇️
...eforge/kolmafia/swingui/panel/GearChangePanel.java 58.74% <0.00%> (-0.14%) ⬇️
...orge/kolmafia/persistence/ConsumablesDatabase.java 70.18% <0.00%> (ø)
src/net/sourceforge/kolmafia/KoLCharacter.java 58.12% <0.00%> (+0.08%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e934a...1583247. Read the comment docs.

@gausie
Copy link
Contributor

gausie commented Nov 7, 2022

Please add a comment explaining the difference between the new functions. Or rename one to addAndEnqueue

@gausie
Copy link
Contributor

gausie commented Nov 7, 2022

Thanks! I would say "ToMap" is overly leaky of the exact implementation but happy to approve. If you want to change it, go ahead.

@midgleyc midgleyc enabled auto-merge (squash) November 8, 2022 18:19
@midgleyc midgleyc merged commit cc7655a into kolmafia:main Nov 8, 2022
@libraryaddict libraryaddict deleted the ball-queue branch February 11, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants