Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UseSkillRequest bugs #1255

Merged
merged 1 commit into from Nov 9, 2022
Merged

Fix UseSkillRequest bugs #1255

merged 1 commit into from Nov 9, 2022

Conversation

Veracity0
Copy link
Contributor

  1. When casting a daily-limited skill that tells you how many casts remain, don't double increment usage
  2. Don't need to equip designer sweatpants to Sweat Out Some Booze
  3. Modernize switch statement in SkillDatabase.isLibramSkill

@Veracity0 Veracity0 requested a review from a team as a code owner November 9, 2022 16:21
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1255 (e320d24) into main (4409975) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1255   +/-   ##
=========================================
  Coverage     32.23%   32.24%           
- Complexity    15841    15846    +5     
=========================================
  Files          1041     1041           
  Lines        162355   162357    +2     
  Branches      35245    35245           
=========================================
+ Hits          52333    52346   +13     
+ Misses       100776   100770    -6     
+ Partials       9246     9241    -5     
Impacted Files Coverage Δ
...ourceforge/kolmafia/persistence/SkillDatabase.java 35.95% <33.33%> (+0.04%) ⬆️
.../sourceforge/kolmafia/request/UseSkillRequest.java 34.91% <100.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4409975...e320d24. Read the comment docs.

@Veracity0 Veracity0 merged commit 03132b6 into main Nov 9, 2022
@Veracity0 Veracity0 deleted the skill-daily-limit-bug branch November 9, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants