New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More test clean up of residue in data/ #1261
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
=========================================
Coverage 32.51% 32.51%
- Complexity 16072 16073 +1
=========================================
Files 1042 1042
Lines 162365 162352 -13
Branches 35257 35257
=========================================
Hits 52790 52790
+ Misses 100289 100276 -13
Partials 9286 9286
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many comments.
Additionally, on the tests: we may want to set it to false in ClearSharedStateBefore
, same as we do for sessionId
, because while the tests are running we never want it true.
src/net/sourceforge/kolmafia/persistence/AdventureQueueDatabase.java
Outdated
Show resolved
Hide resolved
src/net/sourceforge/kolmafia/persistence/AdventureQueueDatabase.java
Outdated
Show resolved
Hide resolved
src/net/sourceforge/kolmafia/persistence/AdventureSpentDatabase.java
Outdated
Show resolved
Hide resolved
src/net/sourceforge/kolmafia/persistence/AdventureSpentDatabase.java
Outdated
Show resolved
Hide resolved
test/net/sourceforge/kolmafia/request/AdventureRequestTest.java
Outdated
Show resolved
Hide resolved
I think I addressed all of @midgleyc 's comments. That said, I think the AfterEach to AfterAll was not the right move. I need to run the tests locally which has gotten harder since something has doubled the wall clock time to do so... |
Local test worked. Thanks. |
Added an option not to write the adventure queue and turns files and then disabled the write in tests that created them but were not cleaning them up.
Changed the username for several tests to make it easier to find which test was leaving files based on the username behind.
Lint and spotless.
Since the tests that got changed were not using the Cleanups framework I elected not to change them to do so. baby steps.