Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test clean up of residue in data/ #1261

Merged
merged 11 commits into from Nov 12, 2022
Merged

More test clean up of residue in data/ #1261

merged 11 commits into from Nov 12, 2022

Conversation

jaadams5
Copy link
Contributor

Added an option not to write the adventure queue and turns files and then disabled the write in tests that created them but were not cleaning them up.

Changed the username for several tests to make it easier to find which test was leaving files based on the username behind.

Lint and spotless.

Since the tests that got changed were not using the Cleanups framework I elected not to change them to do so. baby steps.

@jaadams5 jaadams5 marked this pull request as ready for review November 10, 2022 19:56
@jaadams5 jaadams5 requested a review from a team as a code owner November 10, 2022 19:56
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1261 (a6c4770) into main (dbcf1ff) will increase coverage by 0.00%.
The diff coverage is 81.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1261   +/-   ##
=========================================
  Coverage     32.51%   32.51%           
- Complexity    16072    16073    +1     
=========================================
  Files          1042     1042           
  Lines        162365   162352   -13     
  Branches      35257    35257           
=========================================
  Hits          52790    52790           
+ Misses       100289   100276   -13     
  Partials       9286     9286           
Impacted Files Coverage Δ
...e/kolmafia/persistence/AdventureSpentDatabase.java 34.73% <60.00%> (-5.67%) ⬇️
...e/kolmafia/persistence/AdventureQueueDatabase.java 35.61% <90.90%> (+2.71%) ⬆️
src/net/sourceforge/kolmafia/RequestThread.java 38.18% <0.00%> (+1.21%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcf1ff...a6c4770. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comments.

Additionally, on the tests: we may want to set it to false in ClearSharedStateBefore, same as we do for sessionId, because while the tests are running we never want it true.

@jaadams5
Copy link
Contributor Author

I think I addressed all of @midgleyc 's comments. That said, I think the AfterEach to AfterAll was not the right move. I need to run the tests locally which has gotten harder since something has doubled the wall clock time to do so...

@jaadams5
Copy link
Contributor Author

Local test worked. Thanks.

@jaadams5 jaadams5 merged commit 7f08053 into main Nov 12, 2022
@jaadams5 jaadams5 deleted the seq branch November 12, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants