Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Simplify new equipment list. (#1264)" #1270

Merged
merged 2 commits into from Nov 12, 2022
Merged

Conversation

phulin
Copy link
Contributor

@phulin phulin commented Nov 12, 2022

I misread the profiling results. After running mafia this morning, I noticed it seems to have made things much worse. After looking more closely, I realized I had missed impact on the AWT event queue thread.

I need to spend some more time with this code to see if there's an actually working way to improve performance. For now, I suggest reverting my change from yesterday.

This reverts commit 6e1b0cf.

@phulin phulin requested a review from a team as a code owner November 12, 2022 12:55
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1270 (b4224d6) into main (a3eb525) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1270      +/-   ##
============================================
+ Coverage     32.20%   32.51%   +0.30%     
- Complexity    15914    16071     +157     
============================================
  Files          1042     1042              
  Lines        162364   162365       +1     
  Branches      35257    35257              
============================================
+ Hits          52289    52792     +503     
+ Misses       100888   100288     -600     
- Partials       9187     9285      +98     
Impacted Files Coverage Δ
...eforge/kolmafia/swingui/panel/GearChangePanel.java 58.87% <100.00%> (+0.19%) ⬆️
...lmafia/swingui/widget/ListCellRendererFactory.java 28.00% <0.00%> (-0.48%) ⬇️
src/net/sourceforge/kolmafia/KoLmafiaCLI.java 69.86% <0.00%> (+0.15%) ⬆️
src/net/sourceforge/kolmafia/StaticEntity.java 22.06% <0.00%> (+0.27%) ⬆️
...et/sourceforge/kolmafia/textui/RuntimeLibrary.java 36.02% <0.00%> (+0.30%) ⬆️
src/net/sourceforge/kolmafia/RequestLogger.java 28.67% <0.00%> (+0.41%) ⬆️
...sourceforge/kolmafia/persistence/TCRSDatabase.java 54.62% <0.00%> (+0.43%) ⬆️
...net/sourceforge/kolmafia/textui/DataFileCache.java 43.39% <0.00%> (+0.94%) ⬆️
...forge/kolmafia/textui/langserver/FilesMonitor.java 80.76% <0.00%> (+1.28%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3eb525...b4224d6. Read the comment docs.

@gausie gausie enabled auto-merge (squash) November 12, 2022 13:02
@gausie gausie merged commit dbcf1ff into kolmafia:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants