Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Oliver's Place #1271

Merged
merged 5 commits into from Nov 12, 2022
Merged

feat: Oliver's Place #1271

merged 5 commits into from Nov 12, 2022

Conversation

midgleyc
Copy link
Member

Dump of items, effects, zone etc.

Yeah it's mid outdoor in-game, hope that'll get changed, can recheck later.

@midgleyc midgleyc requested a review from a team as a code owner November 12, 2022 13:46
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1271 (b30383d) into main (5feef17) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1271      +/-   ##
============================================
- Coverage     32.56%   32.55%   -0.02%     
+ Complexity    16137    16135       -2     
============================================
  Files          1042     1042              
  Lines        162445   162445              
  Branches      35279    35279              
============================================
- Hits          52902    52884      -18     
- Misses       100244   100267      +23     
+ Partials       9299     9294       -5     
Impacted Files Coverage Δ
...net/sourceforge/kolmafia/textui/DataFileCache.java 37.73% <0.00%> (-5.67%) ⬇️
...sourceforge/kolmafia/textui/langserver/Script.java 80.85% <0.00%> (-4.26%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 79.48% <0.00%> (-1.29%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 27.52% <0.00%> (-0.48%) ⬇️
...eforge/kolmafia/swingui/panel/GearChangePanel.java 58.60% <0.00%> (-0.28%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 58.11% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5feef17...b30383d. Read the comment docs.

Copy link
Contributor

@Veracity0 Veracity0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. I see all sorts of things that will be needed in code, rather than data (a setting to track whether you've used it. prepareForAdventure, canAdventure support, and so on.

The new zone depends on an item - either the deed or, if there ends up being one, a day-pass.
I assume some of the new items are monster drops.
Is the government per-diem reusable? Once per day, I assume. Breakfast?
Presumably, the deed can only be used once per character and there is a message.
Do we need to record the Steam code? I assume not; presumably, like the horsery, it is on the plaque on the wall.

This is fine for now.

@midgleyc midgleyc enabled auto-merge (squash) November 12, 2022 16:39
@midgleyc
Copy link
Member Author

Yes, there is a lot to add. The pool table gives meat once per day with enough pool skill.

The code is present, but it's on the graffitied table, not the plaque. The plaque lets you rename the place.

@midgleyc midgleyc merged commit 8e82f54 into kolmafia:main Nov 12, 2022
@midgleyc midgleyc deleted the olivers-place branch November 12, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants