New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Oliver's Place #1271
feat: Oliver's Place #1271
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
============================================
- Coverage 32.56% 32.55% -0.02%
+ Complexity 16137 16135 -2
============================================
Files 1042 1042
Lines 162445 162445
Branches 35279 35279
============================================
- Hits 52902 52884 -18
- Misses 100244 100267 +23
+ Partials 9299 9294 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. I see all sorts of things that will be needed in code, rather than data (a setting to track whether you've used it. prepareForAdventure, canAdventure support, and so on.
The new zone depends on an item - either the deed or, if there ends up being one, a day-pass.
I assume some of the new items are monster drops.
Is the government per-diem reusable? Once per day, I assume. Breakfast?
Presumably, the deed can only be used once per character and there is a message.
Do we need to record the Steam code? I assume not; presumably, like the horsery, it is on the plaque on the wall.
This is fine for now.
Yes, there is a lot to add. The pool table gives meat once per day with enough pool skill. The code is present, but it's on the graffitied table, not the plaque. The plaque lets you rename the place. |
Dump of items, effects, zone etc.
Yeah it's mid outdoor in-game, hope that'll get changed, can recheck later.