Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove turn-costing jewelcrafting, add turn-free cooking #1276

Merged
merged 2 commits into from Nov 13, 2022

Conversation

midgleyc
Copy link
Member

Jewelrycrafting doesn't take turns, so remove code that checks free crafts related to it.

Cooking now has a separate source of free crafts, so add the "cookingLimit" and "turnFreeCookingLimit" concoctions. Still not really sure what this area of the code does.

@midgleyc midgleyc requested a review from a team as a code owner November 12, 2022 20:11
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1276 (dd6532b) into main (db0494d) will decrease coverage by 0.00%.
The diff coverage is 67.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1276      +/-   ##
============================================
- Coverage     32.60%   32.60%   -0.01%     
+ Complexity    16180    16179       -1     
============================================
  Files          1042     1042              
  Lines        162471   162471              
  Branches      35282    35283       +1     
============================================
- Hits          52973    52972       -1     
- Misses       100205   100206       +1     
  Partials       9293     9293              
Impacted Files Coverage Δ
...ourceforge/kolmafia/request/CreateItemRequest.java 44.11% <0.00%> (+0.06%) ⬆️
...sourceforge/kolmafia/session/InventoryManager.java 32.54% <0.00%> (+0.11%) ⬆️
...et/sourceforge/kolmafia/objectpool/Concoction.java 67.21% <20.00%> (-0.55%) ⬇️
...forge/kolmafia/persistence/ConcoctionDatabase.java 51.07% <85.71%> (+0.14%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0494d...dd6532b. Read the comment docs.

Copy link
Contributor

@jaadams5 jaadams5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an opportunity for a test?

@midgleyc midgleyc merged commit 667d30e into kolmafia:main Nov 13, 2022
@midgleyc midgleyc deleted the no-jewel-only-cook branch November 13, 2022 19:33
@midgleyc
Copy link
Member Author

Not more than I've already done easily.

Most of the functions are hard to call, or hard to test -- e.g. "what does calculate3 do?" is a reasonable question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants