Improve banish manager tests + ice house handling

[gausie]

• Improve ice house support and modernise BanishManager tests
• Add some missing coverage

[codecov]

Codecov Report

Merging #1283 (08f0fdd) into main (e1505cb) will increase coverage by 0.00%.
The diff coverage is 93.02%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1283   +/-   ##
=========================================
  Coverage     32.63%   32.63%           
- Complexity    16195    16200    +5     
=========================================
  Files          1042     1042           
  Lines        162492   162493    +1     
  Branches      35285    35286    +1     
=========================================
+ Hits          53023    53037   +14     
+ Misses       100163   100156    -7     
+ Partials       9306     9300    -6     

Impacted Files	Coverage Δ
...et/sourceforge/kolmafia/session/ChoiceControl.java	8.54% <50.00%> (ø)
...et/sourceforge/kolmafia/session/BanishManager.java	97.00% <95.12%> (+2.15%)	⬆️
...orge/kolmafia/persistence/ConsumablesDatabase.java	75.59% <0.00%> (ø)
...rceforge/kolmafia/persistence/HolidayDatabase.java	60.98% <0.00%> (+0.25%)	⬆️
.../sourceforge/kolmafia/preferences/Preferences.java	86.34% <0.00%> (+1.62%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1505cb...08f0fdd. Read the comment docs.

[midgleyc]

Thanks!