Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count turns spent on A Deserted Stretch of I-911 #1337

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Conversation

Veracity0
Copy link
Contributor

Do not need Hare-Brained effect to adventure there.
You are given that effect when you attempt to adventure there.
The duration is remaining number of turns available in that zone.

@Veracity0 Veracity0 requested a review from a team as a code owner December 10, 2022 14:59
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #1337 (91e71dc) into main (d64ba2f) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1337   +/-   ##
=========================================
  Coverage     33.17%   33.17%           
- Complexity    16592    16596    +4     
=========================================
  Files          1045     1045           
  Lines        162868   162872    +4     
  Branches      35354    35355    +1     
=========================================
+ Hits          54031    54036    +5     
  Misses        99381    99381           
+ Partials       9456     9455    -1     
Impacted Files Coverage Δ
.../sourceforge/kolmafia/preferences/Preferences.java 86.30% <ø> (ø)
...sourceforge/kolmafia/session/GrimstoneManager.java 30.61% <66.66%> (+1.13%) ⬆️
src/net/sourceforge/kolmafia/KoLAdventure.java 63.21% <100.00%> (-0.03%) ⬇️
.../sourceforge/kolmafia/session/ResultProcessor.java 26.88% <100.00%> (+0.09%) ⬆️
.../sourceforge/kolmafia/request/StandardRequest.java 83.78% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64ba2f...91e71dc. Read the comment docs.

@gausie
Copy link
Contributor

gausie commented Dec 10, 2022

Don't forget to reset on ascension!

@Veracity0
Copy link
Contributor Author

Don't forget to reset on ascension!

There is actually no effect for NOT doing that, since we reset grimstoneMaskPath on ascension, but it is cleaner.

We reset the stepmother and gnome properties on ascension.
Now we reset the candy witch, wolf, and hare properties as well.

@Veracity0 Veracity0 merged commit 232d580 into main Dec 10, 2022
@Veracity0 Veracity0 deleted the grimstone-hare branch December 10, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants