Don't add html to the toString() of PurchaseRequest #1338
Conversation
…tell, it's meaningless as ListCellRenderer handles it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
=========================================
Coverage 33.15% 33.15%
Complexity 16589 16589
=========================================
Files 1045 1045
Lines 162874 162865 -9
Branches 35356 35354 -2
=========================================
- Hits 54008 54005 -3
+ Misses 99414 99407 -7
- Partials 9452 9453 +1
Continue to review full report at Codecov.
|
|
FWIW the code with the HTML does go back to 2013. How confident are you that CellRenderers are the only place that this toString() is used? I'm having difficulty answering that and there are definitely cases where HTML in session logs is considered A Good Thing. I'll approve but someone with more confidence than I about where it is actually used can push. |
|
I can't see anything obvious and I think with our audience we'll know quite quickly if this is having negative effects for people. Thanks! |
As far as I can tell, it's meaningless as ListCellRenderer handles the rendering.
Always found it a little irritating when copying a mall search result came up with
<html><nobr><font color="gray">Manual of Numberology (1 @ 85,000,000): Cheap Stuff Here --></font></nobr></html>Especially when other list cell renderers didn't have this behavior.
So I looked into it, and it appears quite meaningless.
https://github.com/kolmafia/kolmafia/blob/main/src/net/sourceforge/kolmafia/swingui/widget/ListCellRendererFactory.java#L121