New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HTML from CompactSidePane. #1387
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
============================================
- Coverage 33.56% 33.55% -0.01%
Complexity 16747 16747
============================================
Files 1049 1049
Lines 162126 162139 +13
Branches 34849 34849
============================================
Hits 54411 54411
- Misses 98381 98394 +13
Partials 9334 9334
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There looks to be a small unintended change: previously, the tooltip (hover text) on the familiar read "<Familiar type> (X lbs)
". Now it reads "<Player name>'s <Familiar type> (X lbs)
". Can we go back to the previous text?
No, it's exactly there. Mine has the player name before the familiar type. How odd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue unrelated to PR but still weird
Ah, a possibility I didn't consider. WIll fix. |
Much like the equipment PR, rendering HTML in the side pane is unnecessary computational effort. This PR removes HTML from the side pane rendering code in favor of native Java layout tools. It's not a huge speedup but seems to be a reduction of 1-2% of CPU time in my tests.