Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML from CompactSidePane. #1387

Merged
merged 2 commits into from Dec 31, 2022
Merged

Remove HTML from CompactSidePane. #1387

merged 2 commits into from Dec 31, 2022

Conversation

phulin
Copy link
Contributor

@phulin phulin commented Dec 30, 2022

Much like the equipment PR, rendering HTML in the side pane is unnecessary computational effort. This PR removes HTML from the side pane rendering code in favor of native Java layout tools. It's not a huge speedup but seems to be a reduction of 1-2% of CPU time in my tests.

@phulin phulin requested a review from a team as a code owner December 30, 2022 20:28
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #1387 (cdb24cd) into main (e692b14) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1387      +/-   ##
============================================
- Coverage     33.56%   33.55%   -0.01%     
  Complexity    16747    16747              
============================================
  Files          1049     1049              
  Lines        162126   162139      +13     
  Branches      34849    34849              
============================================
  Hits          54411    54411              
- Misses        98381    98394      +13     
  Partials       9334     9334              
Impacted Files Coverage Δ
...eforge/kolmafia/swingui/panel/CompactSidePane.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e692b14...cdb24cd. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There looks to be a small unintended change: previously, the tooltip (hover text) on the familiar read "<Familiar type> (X lbs)". Now it reads "<Player name>'s <Familiar type> (X lbs)". Can we go back to the previous text?

@phulin
Copy link
Contributor Author

phulin commented Dec 31, 2022

Sorry, where do you see that? Here's what mine shows, this must be somewhere else:

image

@midgleyc
Copy link
Member

No, it's exactly there. Mine has the player name before the familiar type. How odd.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue unrelated to PR but still weird

@midgleyc midgleyc merged commit 689d98c into kolmafia:main Dec 31, 2022
@Veracity0
Copy link
Contributor

My hover text is fine.
However.

Screen Shot 2022-12-31 at 12 33 54 PM

@phulin
Copy link
Contributor Author

phulin commented Dec 31, 2022

Ah, a possibility I didn't consider. WIll fix.

@midgleyc midgleyc added the performance Improve Mafia speed / CPU label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve Mafia speed / CPU
Projects
None yet
3 participants