feat: detect rock garden levels #1410
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
============================================
+ Coverage 33.67% 33.68% +0.01%
- Complexity 16803 16813 +10
============================================
Files 1051 1051
Lines 162209 162252 +43
Branches 34842 34859 +17
============================================
+ Hits 54618 54649 +31
- Misses 98222 98224 +2
- Partials 9369 9379 +10
Continue to review full report at Codecov.
|
util/intellij.xml
Outdated
| @@ -0,0 +1,598 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Was this an intentionally commited file?
There was a problem hiding this comment.
Not in this PR. It's the Google Code style. It could be nice to have.
|
Harvest preference is a pain. It only applies to a single garden, and if you change gardens, you have to change it. Perhaps configuration options: 1 groveling gravel, 1 milestone, 1 whetstone Which is say - pick all three gardens on day 1, 2, 3, 4, 5, 6, or 7 Unfortunately, your three gardens CAN all be on different days. Each plot has an item - milestone (0), milestone (1), milestone (2), milestone (3) ... - that tells you the current state of the plot. I.e., what you will get when you pick. This item is a poser. I think, perhaps, the garden command should consider this as 3 gardens. We currently have: garden For the rock garden, "garden pick" should get all three, I think Should we have keywords to name each garden? Wiki refers to them as "Plot 1" "Plot 2" and "Plot 3" |
| || findImage(responseText, "rockgarden/a5.gif", ItemPool.FRUITY_PEBBLE, 2) | ||
| || findImage(responseText, "rockgarden/a6.gif", ItemPool.FRUITY_PEBBLE, 3) | ||
| || findImage(responseText, "rockgarden/a7.gif", ItemPool.LODESTONE, 1)) { | ||
| CampgroundRequest.setCampgroundItem(ItemPool.ROCK_SEEDS, 1); |
There was a problem hiding this comment.
If Plot 1 has from 1-7 days of growth, you add the harvestable crop ITEM (COUNT) - and also rock seeds (1).
| CampgroundRequest.setCampgroundItem(ItemPool.ROCK_SEEDS, 1); | ||
| } else { | ||
| findImage( | ||
| responseText, "rockgarden/a0.gif", ItemPool.GROVELING_GRAVEL, 0, ItemPool.ROCK_SEEDS, 0); |
There was a problem hiding this comment.
If Plot 1 has been harvested today - image 0 - you add ITEM(0) and also rock seeds (0).
Why not rock seeds (1)? That seems like the general indicator of "having a rock garden".
| || findImage(responseText, "rockgarden/b7.gif", ItemPool.MOLEHILL_MOUNTAIN, 1)) { | ||
| CampgroundRequest.setCampgroundItem(ItemPool.ROCK_SEEDS, 1); | ||
| } else { | ||
| findImage(responseText, "rockgarden/b0.gif", ItemPool.MILESTONE, 0, ItemPool.ROCK_SEEDS, 0); |
There was a problem hiding this comment.
And that comes into play here.
What if Plot 1 is still growing but Plot 2 has been harvested to the ground?
The first one added rock seeds (1) and this is now adding rock seeds (0)?
| || findImage(responseText, "rockgarden/c7.gif", ItemPool.STRANGE_STALAGMITE, 1)) { | ||
| CampgroundRequest.setCampgroundItem(ItemPool.ROCK_SEEDS, 1); | ||
| } else { | ||
| findImage(responseText, "rockgarden/c0.gif", ItemPool.WHETSTONE, 0, ItemPool.ROCK_SEEDS, 0); |
There was a problem hiding this comment.
Ditto.
I think you should look for 3 plots images 0-7, add the appropriate plot item, and always add rock seeds (1)
There was a problem hiding this comment.
The other gardens use the count as the number of days the garden has been planted. We can't do that here because it's actually three gardens.
What I was trying for was to do rock seeds = 0 if the rock garden was present but empty and 1 otherwise. However, I did it wrong :P
Detect rock garden levels.
Picking is slightly unusual, haven't yet decided what the best design would be. Might want to interpret this as three "garden"s as they're all individually pickable:
campground.php?action=rgarden1,rgarden2,rgarden3. No idea how to configure this in the harvest preference. Don't really know how the garden command should work either; maybe it should take a number or otherwise do all? I think it's most likely folk will either harvest anything or all on day 7, though.