-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support booze and food fairies #1420
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1420 +/- ##
=========================================
Coverage 33.71% 33.72%
- Complexity 16854 16861 +7
=========================================
Files 1051 1051
Lines 162290 162314 +24
Branches 34867 34867
=========================================
+ Hits 54715 54737 +22
Misses 98191 98191
- Partials 9384 9386 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to handle Peppermint Rhino while you're adding fairy types: the Rhino is a 1x fairy and a 1x candy fairy (for a total of 2x candy drops).
I note this is a case currently not handled by the code -- a familiar is either a food or booze or item fairy, not a combination. It would be nice to sort out this part of the design -- for the difficulty in adding it after the fact, see how other parts of the codebase handle drunki-bears ;)
Hmm ok. This would mean I need to add |
Yeah. I can't really see another way of doing it, and I think it's better than having a Fairy type that switches based on familiar tags. |
That should be it! Thanks for the feedback, this is much better. It would be great to turn Modifiers into an enum, having this numerical key is very annoying. |
the enum type is in #1401, just waiting for final comments ;) edit: oh, unless you meant |
…idn't know modifiers were parsed like this), expand familiars.txt docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Note: this adds new familiar types: item1 and item2